fix: prevent file sidebar clipping on small screens (CB-4260)#245
Open
Gerry-Cern wants to merge 1 commit into
Open
fix: prevent file sidebar clipping on small screens (CB-4260)#245Gerry-Cern wants to merge 1 commit into
Gerry-Cern wants to merge 1 commit into
Conversation
- Changed width properties to use flexbox for better responsiveness. - Added min-height and max-width constraints. - Introduced a new test suite for the SideBar component to ensure proper rendering and responsive behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the right-hand file sidebar (#app-sidebar) could be partially hidden on low-resolution viewports (e.g. 1024×768 at 100% zoom), making context actions in the sidebar (including on public links) hard or impossible to reach.
Change: Allow the sidebar to shrink within the flex layout (flex: 0 1 440px, min-width: 0) and improve vertical scrolling (min-height: 0 on the panel body).
Test plan
Open a public link on a narrow viewport, open the file sidebar and Actions panel; confirm the sidebar is fully visible and actions are reachable.
Unit tests: packages/web-pkg/tests/unit/components/sidebar/SideBar.spec.ts
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: