Add support for redis sentinel config by using redis.UniversalClient which auto-switches based on config#387
Open
andsens wants to merge 1 commit intocesanta:mainfrom
Open
Conversation
Contributor
Author
|
Woops. |
0dd2cd7 to
1335e41
Compare
Contributor
Author
|
Hmpf, I don't see a way of doing this cleanly while preserving legacy configs. I suggest breaking compatibility and simplifying the entire thing (looks around, ducks). |
This implicitly adds support for redis sentinel HA configuration
1335e41 to
1898e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the nice code changes where we can add more capability with the tiniest diff:
redis-go has a
UniversalClientwhich automatically detects which redis client to use (simple,cluster, orsentinel) based on this piece of code.Meaning, this PR introduces support for redis sentinel (HA failover) and also obsoletes the special
redis_cluster_optionssetting. I haven't removed it though (legacy support). At some point a deprecation warning might be in order though.