Add a pool maxsize and remove superfluous connection method#245
Merged
Conversation
higs4281
approved these changes
Jun 16, 2026
chosak
reviewed
Jun 16, 2026
| f"http://{host}:{_ES_PORT}", | ||
| use_ssl=(str(_ES_PORT) == "443"), | ||
| timeout=100, | ||
| pool_maxsize=10 |
Member
There was a problem hiding this comment.
Didn't want to add an ES_POOL_MAXSIZE environment variable that defaults to 10?
Member
Author
There was a problem hiding this comment.
That certainly would have been a nice, tunable thing :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pool_maxsize so that we don't get the default pool size of 1.
Also, we don't use AWS4Auth in any current scenario, so that's been removed.