Skip to content

Alerts w/ links update#608

Open
flacoman91 wants to merge 2 commits into
mainfrom
rad-alert-links
Open

Alerts w/ links update#608
flacoman91 wants to merge 2 commits into
mainfrom
rad-alert-links

Conversation

@flacoman91

@flacoman91 flacoman91 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Ans said about the Alert with links component:

One potential issue I'd flag with this is if you want to use other link attributes (target, rel, etc.), or add different icons (e.g. a download icon), all those additional permuations have to be built into the links attribute. I wonder if a better model may be to pass in a separate link component, e.g.:

<Alert
  message="Information alert"
  status="info"
>
  This is the explanation of the alert.
  <Link href="/">This is a link below the explanation</Link>
  <Link href="/" iconRight="external-link">This is a link below the explanation</Link>
</Alert>

Updating the Alert component to accept <ListLink instead of a configurable object.
Remove alert-link component bc it seems like a redundant wrapper to the Link

To test, compare:

https://cfpb.github.io/design-system-react/pr-previews/pr-608/?path=/docs/components-draft-alerts--overview
vs prod
https://cfpb.github.io/design-system-react/?path=/docs/components-draft-alerts--overview

everything should appear the same

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cfpb.github.io/design-system-react/pr-previews/pr-608/

Built to branch gh-pages at 2026-06-05 23:06 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant