feat(contracts): add managed flag#3108
Open
migmartri wants to merge 1 commit into
Open
Conversation
Adds a managed boolean to workflow contracts to mark resources provisioned and operated by Chainloop. Managed contracts cannot be updated or deleted by users. Mirrors the same flag added for CAS backends in chainloop-dev#3092. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
There was a problem hiding this comment.
1 issue found across 19 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/controlplane/pkg/biz/workflowcontract.go">
<violation number="1" location="app/controlplane/pkg/biz/workflowcontract.go:416">
P2: Add tests for the new managed-contract guards in Update and Delete. These are new authorization/validation branches and currently have no matching test coverage.
(Based on your team's feedback about adding or updating tests for new paths.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| } | ||
|
|
||
| // Managed contracts are owned and operated by Chainloop and cannot be modified by users. | ||
| if wfContractPreUpdate.Managed { |
There was a problem hiding this comment.
P2: Add tests for the new managed-contract guards in Update and Delete. These are new authorization/validation branches and currently have no matching test coverage.
(Based on your team's feedback about adding or updating tests for new paths.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At app/controlplane/pkg/biz/workflowcontract.go, line 416:
<comment>Add tests for the new managed-contract guards in Update and Delete. These are new authorization/validation branches and currently have no matching test coverage.
(Based on your team's feedback about adding or updating tests for new paths.) </comment>
<file context>
@@ -408,6 +412,11 @@ func (uc *WorkflowContractUseCase) Update(ctx context.Context, orgID, name strin
}
+ // Managed contracts are owned and operated by Chainloop and cannot be modified by users.
+ if wfContractPreUpdate.Managed {
+ return nil, NewErrValidationStr("managed contracts cannot be modified")
+ }
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
managedboolean to workflow contracts to mark resources provisioned and operated by Chainloop. Managed contracts cannot be updated or deleted by users.Mirrors the same flag added for CAS backends in #3092:
managedfield on theworkflow_contractsEnt schema (defaultfalse)Managedexposed onbiz.WorkflowContract;ContractCreateOptsacceptsManaged *boolfor internal callersUpdateandDeleteuse cases return a validation error when the contract is managedis_managedonWorkflowContractItemin the APIDisclosure
Assisted by Claude Code.