-
Notifications
You must be signed in to change notification settings - Fork 1
Pin remaining GitHub Actions #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the GitHub Actions workflow to pin actions/checkout to a specific commit SHA instead of using the v4 tag reference, improving security and consistency by making all external Actions use commit SHAs.
Changes:
- Replaced three instances of
actions/checkout@v4with the pinned commit SHA0c366fd6a839edf440554fa01a7085ccba70ac98
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you Tijmen! I understand the sentiment, and while I think it is not the most important thing in the world, it definitely cannot hurt to pin GitHub's own actions as well. @OpsBotPrime merge |
|
Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command |
|
@OpsBotPrime merge on Friday |
|
Rebased as 4809da9, waiting for CI … |
|
CI job 🟡 started. |
|
The build failed ❌. If this is the result of a flaky test, then tag me again with the |
|
@OpsBotPrime retry on Friday |
|
Rebased as 4809da9, waiting for CI … |
|
CI job 🟡 started. |
Part of https://github.com/channable/devops/issues/13319.
Some people argued that it would be more consistent if we also pinned GitHub owned (i.e. github.com/actions/checkout) Actions.