In tests on CI, store the test DBs in memory to fix self-hosted Semaphore runners sometimes hanging #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hore runners sometimes hanging
Contributor
Author
|
@OpsBotPrime merge |
Contributor
|
Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command |
Contributor
Author
|
@OpsBotPrime merge on Friday |
Contributor
|
Rebased as 1f4f66b, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with high certainty the cause of the Semaphore hangs we have seen in the past, which took @rlycx, @ReinierMaas, @SanderHageman and myself a huuuge amount of work to debug: There is an interaction between writing a file to
/tmp/(which, to my surprise, is not atmpfsin Semaphore) on Butterfs when using many small fsyncs (which as it turns out, Sqlite does when initializing a new DB, esp in WAL mode), and then doing this for dozens of tests in parallel.This will cause one of these
fsyncs to hang for many minutes on end, with the OS busy doing some kind of disk vacuuming.This PR changes Opsqueue to run in a 100% in-memory mode in the integration test suite instead.