feat: Add number_of_keys to statistics#8297
Open
Hocuri wants to merge 1 commit into
Open
Conversation
link2xt
approved these changes
Jun 2, 2026
iequidoo
approved these changes
Jun 2, 2026
| core_version: String, | ||
| number_of_transports: usize, | ||
| key_create_timestamps: Vec<u32>, | ||
| number_of_keys: u32, |
Collaborator
There was a problem hiding this comment.
Better usize for consistency with number_of_transports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 3b29469, all public keys except for the currently-used one are ignored. But Delta Chat still tries to use all private keys for decryption.
This PR adds the information how many keys there are in the database. If there is more than one, we know that the user imported their own key back when that was possible. This info is interesting both for ourselves and for the Cispa researchers that want to write a paper about Delta Chat.
An alternative to this PR would be to make
key_create_timestampsactually contain the full list of key creation timestamps. I'm not sure if that's worth the effort, though.Follow-up to #8293