Skip to content

Conversation

@jheng-hao-lin-cko
Copy link
Contributor

@jheng-hao-lin-cko jheng-hao-lin-cko commented Oct 14, 2025

Issue

pimob-4057

Proposed changes

Updates the Gradle wrapper, Android Gradle Plugin, and related configurations to support 16KB page size mandate

  • Bumps kotlin version from 1.9.10 to 2.2.20
  • Bumps Gradle wrapper from 8.2.1 to 8.13.
  • Upgrades Android Gradle Plugin from 8.1.2 to 8.12.3.
  • Updates Dagger from 2.48.1 to 2.57.2
  • Replaces kapt with ksp for annotation processing.
  • Updates various testing dependencies to their latest versions.
  • Refactors build scripts to align with newer Gradle and Kotlin DSL practices, including the removal of kotlinOptions and jcenter.
  • Replaces deprecated Uri.parse with toUri() from AndroidX Core.

Test Step

  1. Create a new Android application module
  2. Add implementation("com.github.checkout:frames-android:<version>") in the app build.gradle
  3. build apk, and use apk analyzer to verify the apk is supporting 16KB page size.

Checklist

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

@jheng-hao-lin-cko jheng-hao-lin-cko requested a review from a team as a code owner October 14, 2025 12:49
@jheng-hao-lin-cko jheng-hao-lin-cko self-assigned this Oct 14, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the Android Gradle Plugin (AGP) from 8.1.2 to 8.12.3 and Gradle wrapper from 8.2.1 to 8.13 to support Android's 16KB page size mandate. This is a maintenance upgrade to ensure compatibility with future Android requirements.

  • Updated Gradle wrapper from 8.2.1 to 8.13
  • Upgraded Android Gradle Plugin from 8.1.2 to 8.12.3
  • Modernized deprecated lint configuration syntax

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
gradle/wrapper/gradle-wrapper.properties Updates Gradle distribution URL to version 8.13
buildSrc/gradle.properties Updates AGP version property to 8.12.3
buildSrc/build.gradle.kts Updates AGP dependency version to 8.12.3
app/build.gradle Migrates from deprecated lintOptions to modern lint block

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jheng-hao-lin-cko jheng-hao-lin-cko marked this pull request as draft October 14, 2025 12:50
@jheng-hao-lin-cko jheng-hao-lin-cko marked this pull request as ready for review October 14, 2025 12:50
@jheng-hao-lin-cko jheng-hao-lin-cko marked this pull request as draft October 14, 2025 12:57
@jheng-hao-lin-cko jheng-hao-lin-cko force-pushed the feature/PIMOB-4057-support_16kb_page_size branch 4 times, most recently from 855d6b7 to 8f17d38 Compare October 14, 2025 15:22
@jheng-hao-lin-cko jheng-hao-lin-cko changed the title feat/pimob-4057: Upgrade AGP to 8.12.3 feat/pimob-4057: Support 16KB size page setup Oct 14, 2025
@jheng-hao-lin-cko jheng-hao-lin-cko force-pushed the feature/PIMOB-4057-support_16kb_page_size branch from 8f17d38 to 2e338ee Compare October 14, 2025 17:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 28 out of 30 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jheng-hao-lin-cko jheng-hao-lin-cko force-pushed the feature/PIMOB-4057-support_16kb_page_size branch from 2e338ee to 1ac16f2 Compare October 14, 2025 17:51
Updates the Gradle wrapper, Android Gradle Plugin, and related configurations.

- Bumps Gradle wrapper from 8.2.1 to 8.13.
- Upgrades Android Gradle Plugin from 8.1.2 to 8.12.3.
@jheng-hao-lin-cko jheng-hao-lin-cko force-pushed the feature/PIMOB-4057-support_16kb_page_size branch from 1ac16f2 to 4eaa764 Compare October 14, 2025 17:55
@sonarqubecloud
Copy link

@jheng-hao-lin-cko jheng-hao-lin-cko marked this pull request as ready for review October 14, 2025 17:56
@jheng-hao-lin-cko jheng-hao-lin-cko merged commit 082fe33 into master Oct 15, 2025
36 of 38 checks passed
@jheng-hao-lin-cko jheng-hao-lin-cko deleted the feature/PIMOB-4057-support_16kb_page_size branch October 15, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants