Support for Bubble timeline on Akkoma and Chuckya

[Steffo99]

Closes #601.

Still very work in progress, but wanted to share it in the meantime!

Screenshot

Not really necessary, but all pull requests look nicer with images!

[Steffo99]

Figured out how to add it to the shortcut menu, but I'm struggling to understand how to add a new input type to the shortcut settings (the "variant" option would need a <select>).

For now I've set its type to "text", and I'm having the user input the string corresponding to the chosen variant manually.

More screenshots!

[Steffo99]

This works everywhere now, and even has a proper dropdown:

I think I also stumbled upon a bug in the import of shortcuts, which I think I fixed in 369935f.

[Steffo99]

CCing @TheEssem, who might (or might not) be interested in this implementation, as author of TheEssem/mastodon@07ff6d0

[donfeduardo]

I think I managed to fix the merge conflicts on my fork without botching anything, so I have this running on my instance. If there's anything in particular you want another pair of eyes on, let me know.

[donfeduardo]

This is perhaps a dumb question, and I swear I've searched, but what's the best way to deal with merge conflicts on the default PO file at src/locals/en.po? When I first merged this branch I just manually looked for the strings in question as a way to learn how the code worked, but that's impractical. When watching the build output after merging with the current release, I saw messages from lingui extract. Should I be running npm run messages:extract on its own, should I just run a build after a merge and let the file be replaced that way before committing it to my local repo, or is there some other best practice I should be following?

[Steffo99]

"Should I be running npm run messages:extract on its own, should I just run a build after a merge and let the file be replaced that way before committing it to my local repo, or is there some other best practice I should be following?"
—@donfeduardo

I think just running a build should be enough for the relevant files to be replaced, although I never really explored how the localization system works, so perhaps @cheeaun might be able to provide a better answer :)

[paulo-roger]

Thank you so much! Is it implemented?

[Steffo99]

Rebased onto 226fd66 and reorganized commits to be atomic.

@cheeaun please have a look when you can!

[cheeaun]

@Steffo99 this has been a while 😮‍💨. Would be useful to see some screenshots of this working 😁

[Steffo99]

A few more screenshots!

[Steffo99]

Do we have a way to check supports for the instance we're viewing, instead of the one we're logged in to?

This breaks from Mastodon to Pixelfed or between Akkoma and anything else...

[donfeduardo]

It seems to be time to rebase this again, since src/pages/public.jsx has changed recently. Also in fixing the merge conflicts this time around I discovered a couple bugs:

1. The endpoint variable gets set to the bubble timeline on every load. This breaks the local and federated timelines. I solved this by changing the conditional to if(supports('@akkoma/bubble-timeline') && variant === 'bubble')
2. Even when that's properly set, if you switch between the bubble timeline and one of the other views, the list isn't reset. I solved this one with if (publicIterator.endpoint && publicIterator.endpoint != endpoint) { publicIterator.current = undefined; } publicIterator.endpoint = endpoint;

AFAICT this doesn't have any negative side effects, and the list properly reloads if the active timeline is switched.

[Steffo99]

I'm not too interested in working on rebasing this at the moment @donfeduardo, should I add you as contributor to my fork so that you can edit this pull request?

[donfeduardo]

Sure, why not. I don't know if anybody else but me is even trying to use this, but I'd love to have easier merges even if I have to make them happen myself.

[Steffo99]

done!