Fix wasm-bindgen initialization function warning#35
Open
Destructor17 wants to merge 1 commit intochemicstry:mainfrom
Open
Fix wasm-bindgen initialization function warning#35Destructor17 wants to merge 1 commit intochemicstry:mainfrom
Destructor17 wants to merge 1 commit intochemicstry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had to fork wasm_thread to add some specific features like async entrypoint and post_message. I hope to upstream these changes later, but first things first.
JS shim initialization function generated by new versions of wasm-bindgen now looks like this:
It excepts both module and memory to be passed using one object (see diff), otherwise logs a warning.
This PR also contains some changes my IDE did without asking me, but I guess it's for good.