Skip to content

ci: upgrade artifact actions to v4 #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gatoniel wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: upgrade artifact actions to v4 #1399

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0789d7a
ci: upgrade artifact actions to v4
gatoniel Oct 22, 2024
9418c86
fix: correct notation for {{ and }} in template
gatoniel Oct 22, 2024
c560c26
refactor: use jinja {% raw %}
gatoniel Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions {{cookiecutter.project_name}}/.github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,17 @@ jobs:

- name: Upload coverage data
if: always() && matrix.session == 'tests'
uses: "actions/upload-artifact@v3"
uses: actions/upload-artifact@v4
with:
name: coverage-data
{% raw %}
name: coverage-data-${{ matrix.python }}-${{ matrix.os }}
{% endraw %}
Comment on lines +102 to +104
Copy link

@bosd bosd Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these % raw tags needed?

Copy link
Author

@gatoniel gatoniel Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the line would look like this:

          name: coverage-data-${{"{{"}} matrix.python {{"}}"}}-${{"{{"}} matrix.os {{"}}"}}

This was suggested by @webknjaz

Copy link

@webknjaz webknjaz Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosd it's usually cleaner to wrap chunks of mustache that shouldn't be rendered this way. I find that seeing {{ '{{' }} all over the place doesn't help readability.

path: ".coverage.*"
include-hidden-files: true

- name: Upload documentation
if: matrix.session == 'docs-build'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: docs
path: docs/_build
Expand Down Expand Up @@ -138,9 +141,10 @@ jobs:
nox --version

- name: Download coverage data
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage-data
pattern: coverage-data-*
merge-multiple: true

- name: Combine coverage data and display human readable report
run: |
Expand Down