feat(ui): build legacy variant #7472

jacekradko · 2025-12-15T20:43:46Z

Description

Add legacy @clerk/ui build

Fixes: USER-4210

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Summary by CodeRabbit

New Features
- Added an explicit legacy browser build/compatibility variant with a dedicated entry point.
- Enabled legacy bundle monitoring and expanded coverage to track many additional UI bundles with increased size thresholds.
Chores
- Added runtime polyfill support (core-js) and helper tooling (@swc/helpers) for legacy builds.
- Updated package metadata with a legacy browserslist/publishConfig, workspace catalog entries, and an accompanying changeset.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

vercel · 2025-12-15T20:43:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	Dec 19, 2025 3:59pm

changeset-bot · 2025-12-15T20:43:54Z

🦋 Changeset detected

Latest commit: 5ef0ad6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Minor
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-12-15T20:44:02Z

📝 Walkthrough

Walkthrough

Adds a legacy browser build for the UI package. New file packages/ui/src/index.legacy.browser.ts and a changeset .changeset/legacy-browser-variant.md were added. packages/ui/rspack.config.js now builds two UMD browser bundles (modern and legacy), with commonForProdBrowser accepting an options object ({ targets, useCoreJs }) and prodConfig returning an array of configurations; core-js aliasing is selectable. packages/ui/package.json gains @swc/helpers, core-js, and a root-level browserslistLegacy field. packages/ui/bundlewatch.config.json introduces ./dist/ui.legacy.browser.js plus many new bundle entries and updated maxSize thresholds.

Pre-merge checks

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'feat(ui): build legacy variant' clearly and concisely describes the main change: adding legacy variant build support for the UI package, which directly aligns with the changeset and configuration updates.
Linked Issues check	✅ Passed	The PR addresses USER-4210 by implementing legacy variant build support with Safari 12 compatibility through new build configurations (rspack.config.js), package.json updates with polyfill dependencies, and bundlewatch configuration for the legacy browser bundle.
Out of Scope Changes check	✅ Passed	All changes are in scope: legacy variant build infrastructure (rspack.config, entry points, bundlewatch), necessary dependency management (core-js, @swc/helpers), and workspace catalog updates for dependency consistency.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cea3f85 and 5ef0ad6.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

packages/clerk-js/package.json (1 hunks)
packages/ui/package.json (2 hunks)
pnpm-workspace.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

packages/ui/package.json
pnpm-workspace.yaml

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

packages/clerk-js/package.json

packages/*/package.json

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/*/package.json: Packages should export TypeScript types alongside runtime code
Follow semantic versioning for all packages

All packages must be published under @clerk namespace

packages/*/package.json: Framework packages should depend on @clerk/clerk-js for core functionality
@clerk/shared should be a common dependency for most packages in the monorepo

Files:

packages/clerk-js/package.json

**/package.json

📄 CodeRabbit inference engine (.cursor/rules/global.mdc)

Use pnpm as the package manager for this monorepo

Files:

packages/clerk-js/package.json

**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

packages/clerk-js/package.json

**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

packages/clerk-js/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)

GitHub Check: Integration Tests (react-router, chrome)
GitHub Check: Integration Tests (quickstart, chrome, 16)
GitHub Check: Integration Tests (machine, chrome)
GitHub Check: Integration Tests (nextjs, chrome, 16)
GitHub Check: Integration Tests (billing, chrome)
GitHub Check: Integration Tests (nuxt, chrome)
GitHub Check: Integration Tests (quickstart, chrome, 15)
GitHub Check: Integration Tests (nextjs, chrome, 15)
GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
GitHub Check: Integration Tests (custom, chrome)
GitHub Check: Integration Tests (machine, chrome, RQ)
GitHub Check: Integration Tests (billing, chrome, RQ)
GitHub Check: Integration Tests (express, chrome)
GitHub Check: Integration Tests (sessions:staging, chrome)
GitHub Check: Integration Tests (vue, chrome)
GitHub Check: Integration Tests (handshake:staging, chrome)
GitHub Check: Integration Tests (sessions, chrome)
GitHub Check: Integration Tests (ap-flows, chrome)
GitHub Check: Integration Tests (handshake, chrome)
GitHub Check: Integration Tests (localhost, chrome)
GitHub Check: Integration Tests (astro, chrome)
GitHub Check: Integration Tests (tanstack-react-start, chrome)
GitHub Check: Integration Tests (generic, chrome)
GitHub Check: Formatting | Dedupe | Changeset
GitHub Check: Build Packages
GitHub Check: Analyze (javascript-typescript)
GitHub Check: semgrep-cloud-platform/scan

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between eb51fae and cd6e266.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

packages/ui/package.json (3 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

packages/ui/package.json

packages/*/package.json

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/*/package.json: Packages should export TypeScript types alongside runtime code
Follow semantic versioning for all packages

All packages must be published under @clerk namespace

packages/*/package.json: Framework packages should depend on @clerk/clerk-js for core functionality
@clerk/shared should be a common dependency for most packages in the monorepo

Files:

packages/ui/package.json

**/package.json

📄 CodeRabbit inference engine (.cursor/rules/global.mdc)

Use pnpm as the package manager for this monorepo

Files:

packages/ui/package.json

**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

packages/ui/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)

GitHub Check: Integration Tests (billing, chrome, RQ)
GitHub Check: Integration Tests (handshake:staging, chrome)
GitHub Check: Integration Tests (handshake, chrome)
GitHub Check: Integration Tests (nuxt, chrome)
GitHub Check: Integration Tests (quickstart, chrome, 15)
GitHub Check: Integration Tests (billing, chrome)
GitHub Check: Integration Tests (quickstart, chrome, 16)
GitHub Check: Integration Tests (machine, chrome, RQ)
GitHub Check: Integration Tests (nextjs, chrome, 15)
GitHub Check: Integration Tests (ap-flows, chrome)
GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
GitHub Check: Integration Tests (nextjs, chrome, 16)
GitHub Check: Integration Tests (machine, chrome)
GitHub Check: Integration Tests (custom, chrome)
GitHub Check: Integration Tests (generic, chrome)
GitHub Check: Integration Tests (sessions, chrome)
GitHub Check: Integration Tests (react-router, chrome)
GitHub Check: Integration Tests (vue, chrome)
GitHub Check: Integration Tests (express, chrome)
GitHub Check: Integration Tests (astro, chrome)
GitHub Check: Integration Tests (tanstack-react-start, chrome)
GitHub Check: Integration Tests (localhost, chrome)
GitHub Check: Integration Tests (sessions:staging, chrome)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: semgrep-cloud-platform/scan

🔇 Additional comments (1)

packages/ui/package.json (1)

93-93: No changes needed. Version 0.5.17 is the latest release of @swc/helpers with no known security vulnerabilities.

packages/ui/package.json

pkg-pr-new · 2025-12-15T22:33:50Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7472

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7472

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7472

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7472

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7472

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7472

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7472

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7472

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7472

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7472

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7472

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7472

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7472

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7472

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7472

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7472

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7472

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7472

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7472

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7472

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7472

commit: 5ef0ad6

dstaley · 2025-12-19T15:23:32Z

packages/ui/package.json

    "@solana/wallet-adapter-base": "catalog:module-manager",
    "@solana/wallet-adapter-react": "catalog:module-manager",
    "@solana/wallet-standard": "catalog:module-manager",
+    "@swc/helpers": "^0.5.17",


should we put this as a catalog dependency as well?

feat(ui): build legacy variant

306f432

github-actions bot added the core-3 label Dec 15, 2025

wip

eb51fae

vercel bot temporarily deployed to Preview December 15, 2025 20:44 Inactive

wip

cd6e266

vercel bot deployed to Preview December 15, 2025 22:25 View deployment

wip

316ad8f

vercel bot deployed to Preview December 15, 2025 22:28 View deployment

coderabbitai bot reviewed Dec 15, 2025

View reviewed changes

packages/ui/package.json Outdated Show resolved Hide resolved

packages/ui/package.json Show resolved Hide resolved

wip

e7d8e0d

vercel bot deployed to Preview December 15, 2025 22:30 View deployment

Merge branch 'main' into feat/ui-legacy-variant

c87c64e

vercel bot deployed to Preview December 16, 2025 03:09 View deployment

Merge branch 'main' into feat/ui-legacy-variant

54c2c56

vercel bot deployed to Preview December 19, 2025 02:22 View deployment

update bundlewatch config

160c946

vercel bot deployed to Preview December 19, 2025 02:39 View deployment

wip

b9dc5e3

github-actions bot added the clerk-js label Dec 19, 2025

vercel bot deployed to Preview December 19, 2025 02:42 View deployment

wip

584a48a

vercel bot deployed to Preview December 19, 2025 02:53 View deployment

Merge branch 'main' into feat/ui-legacy-variant

cea3f85

jacekradko requested a review from dstaley December 19, 2025 03:26

vercel bot deployed to Preview December 19, 2025 03:27 View deployment

dstaley approved these changes Dec 19, 2025

View reviewed changes

move @swc/helpers to catalog:repo

5ef0ad6

vercel bot deployed to Preview December 19, 2025 15:59 View deployment

jacekradko merged commit 8a49ea7 into main Dec 19, 2025
73 of 74 checks passed

jacekradko deleted the feat/ui-legacy-variant branch December 19, 2025 16:32

brkalow pushed a commit that referenced this pull request Jan 5, 2026

feat(ui): build legacy variant (#7472)

9e2eaa4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ui): build legacy variant #7472

feat(ui): build legacy variant #7472

Uh oh!

jacekradko commented Dec 15, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

Walkthrough

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

dstaley Dec 19, 2025

Uh oh!

jacekradko Dec 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(ui): build legacy variant #7472

feat(ui): build legacy variant #7472

Uh oh!

Conversation

jacekradko commented Dec 15, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Summary by CodeRabbit

Uh oh!

vercel bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Pre-merge checks

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dstaley Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

jacekradko Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jacekradko commented Dec 15, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Dec 15, 2025 •

edited

Loading

changeset-bot bot commented Dec 15, 2025 •

edited

Loading

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

pkg-pr-new bot commented Dec 15, 2025 •

edited

Loading