fix(localizations): add placeholders for email, name fields and legal consent in hu-HU#8080
Conversation
🦋 Changeset detectedLatest commit: cc30d10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@tornaia is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
0a54c13 to
0a3b71f
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis change updates the Hungarian localization by adding a 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
… consent in hu-HU
0a3b71f to
c8399b7
Compare
|
Dear @dmoerner , I saw your name on another localization PR, so I chose you. Could you help me with the review/merge of this PR? It's not urgent, I just want to know if it's okay with you as it is and if I can count on it being merged? |
| label__onlyTermsOfService: undefined, | ||
| label__termsOfServiceAndPrivacyPolicy: undefined, | ||
| label__onlyPrivacyPolicy: 'Elfogadom az {{ privacyPolicyLink || link("Adatkezelési Tájékoztatót") }}', | ||
| label__onlyTermsOfService: 'Elfogadom az {{ termsOfServiceLink || link("Általános Szerződési Feltételeket") }}', |
There was a problem hiding this comment.
I do not know Hungarian, but I see that in our existing localization for the Clerk terms of service in the footer, we use "Felhasználási feltételek" which seems slightly different. Which do you think is best?
There was a problem hiding this comment.
Hi @dmoerner,
Thank you for pointing out the existing translations.
In the footer, compactness is key, so the current "Felhasználási feltételek" works well given the space constraints. However, for the sign-up page, legal accuracy is the primary consideration. "Általános Szerződési Feltételek" (ÁSZF) is the standard Hungarian legal terminology, and since there is more space available there, I would prefer the version in this PR.
While I didn't initially account for every use case, I believe this distinction between the footer and the registration flow is the most professional approach. What do you think?
Description
Added some missing Hungarian translations for
localizations:Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit