Skip to content

fix(clerk-js): Harden useEnabledThirdPartyProviders against missing sso data #8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anagstef wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

fix(clerk-js): Harden useEnabledThirdPartyProviders against missing sso data #8123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3af9c34
Harden useEnabledThirdPartyProviders against missing/empty social pro…
anagstef Mar 19, 2026
7026451
Add changeset
anagstef Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/harden-social-provider-strategies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@clerk/clerk-js": patch
"@clerk/ui": patch
---

Guard against empty social provider strategies from FAPI to prevent crashes in `useEnabledThirdPartyProviders`
4 changes: 2 additions & 2 deletions packages/clerk-js/src/core/resources/UserSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class UserSettings extends BaseResource implements UserSettingsResource {
}

return Object.entries(this.social)
.filter(([, desc]) => desc.enabled && desc.authenticatable)
.filter(([, desc]) => desc.enabled && desc.authenticatable && desc.strategy)
.map(([, desc]) => desc.strategy)
.sort();
}
Expand All @@ -157,7 +157,7 @@ export class UserSettings extends BaseResource implements UserSettingsResource {
}

return Object.entries(this.social)
.filter(([, desc]) => desc.enabled)
.filter(([, desc]) => desc.enabled && desc.strategy)
.map(([, desc]) => desc.strategy)
.sort();
}
Expand Down
2 changes: 2 additions & 0 deletions packages/ui/src/hooks/useEnabledThirdPartyProviders.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ export const useEnabledThirdPartyProviders = () => {
);

allCustomOAuthProviders.forEach(s => {
if (!social[s]) return;
const providerName = s.replace('oauth_', '') as OAuthProvider;
providerToDisplayData[providerName] = {
strategy: s,
Expand All @@ -90,6 +91,7 @@ export const useEnabledThirdPartyProviders = () => {
});

activeCustomSocialStrategies.forEach(s => {
if (!social[s]) return;
const providerId = s.replace('oauth_', '') as OAuthProvider;
strategyToDisplayData[s] = {
id: providerId,
Expand Down
Loading