fix: exclude internal Clerk classes from structural CSS detection#8142
fix: exclude internal Clerk classes from structural CSS detection#8142
Conversation
Only user-authored customization targeting Clerk's public APIs should trigger the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated by Emotion are implementation details and shouldn't be flagged. However, if a user explicitly references .cl-internal-* in their appearance.elements configuration, that's still a stability risk and will be warned about. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe changes introduce handling for internal Clerk-generated classes ( 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with
.cl-internal-*selectors) were triggering warnings on fresh installs without any custom CSS.Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference
.cl-internal-*in theirappearance.elementsconfiguration, that's still warned about since it's a stability risk.Type of change
Summary by CodeRabbit
Tests
Bug Fixes