Skip to content

fix(e2e): skip keyless dashboard tests in staging#8145

Closed
jacekradko wants to merge 1 commit intomainfrom
jacek/skip-keyless-staging
Closed

fix(e2e): skip keyless dashboard tests in staging#8145
jacekradko wants to merge 1 commit intomainfrom
jacek/skip-keyless-staging

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Mar 20, 2026

Summary

  • Skip keyless tests that navigate to the staging dashboard in E2E_STAGING mode
  • The staging dashboard (dashboard.clerkstage.dev) is behind Vercel SSO, so claim flow tests time out waiting for a Clerk sign-in page that never appears
  • Only skips tests that open the dashboard (claim, missing keys); other keyless tests (redirect loop, env restart) still run in staging
  • Uses Playwright's built-in test.skip() with reason, following existing patterns for framework/version skips

Tests skipped in staging:

  • next-quickstart-keyless.test.ts — "Toggle collapse popover and claim", "Lands on claimed application..."
  • react-router/keyless.test.ts — same two tests
  • tanstack-start/keyless.test.ts — same two tests

Test plan

  • Verified from CI traces that all 3 keyless failures navigate to vercel.com/login instead of dashboard.clerkstage.dev/apps/claim/sign-in
  • Non-dashboard keyless tests (redirect loop, env restart) are unaffected

Summary by CodeRabbit

  • Tests
    • Two keyless authentication tests now conditionally skip execution in staging environment across multiple framework integrations (Next.js, React Router, and TanStack Start).

The staging dashboard (dashboard.clerkstage.dev) is behind Vercel SSO,
so keyless claim tests that navigate to the dashboard cannot complete.
Skip only the tests that open the dashboard; other keyless tests
(redirect loop, env restart) still run.
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2026

⚠️ No Changeset found

Latest commit: 7082092

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 20, 2026 9:31pm

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8145

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8145

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8145

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8145

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8145

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8145

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8145

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8145

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8145

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8145

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8145

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8145

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8145

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8145

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8145

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8145

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8145

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8145

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8145

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8145

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8145

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8145

commit: 7082092

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: c4f2da61-a32f-4612-b09b-5105811cef6c

📥 Commits

Reviewing files that changed from the base of the PR and between 9b71736 and 7082092.

📒 Files selected for processing (3)
  • integration/tests/next-quickstart-keyless.test.ts
  • integration/tests/react-router/keyless.test.ts
  • integration/tests/tanstack-start/keyless.test.ts

📝 Walkthrough

Walkthrough

Two keyless-related Playwright tests are modified across three integration test files to conditionally skip execution when the E2E_STAGING environment variable is set to '1'. The affected tests include "Toggle collapse popover and claim" and "Lands on claimed application with missing explicit keys, expanded by default, click to get keys from dashboard." The skip reason cited is that the staging dashboard is behind Vercel SSO. Each of the three test files receives two additional lines of code with no lines removed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: skipping keyless dashboard tests in staging environment due to Vercel SSO blocking.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jacekradko
Copy link
Member Author

Closing in favor of passing VERCEL_AUTOMATION_BYPASS_SECRET to the staging workflow (committed directly to main: 6540d1b). The bypass secret should allow keyless tests to access the staging dashboard without hitting Vercel SSO.

@jacekradko jacekradko closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant