fix(e2e): skip keyless dashboard tests in staging#8145
fix(e2e): skip keyless dashboard tests in staging#8145jacekradko wants to merge 1 commit intomainfrom
Conversation
The staging dashboard (dashboard.clerkstage.dev) is behind Vercel SSO, so keyless claim tests that navigate to the dashboard cannot complete. Skip only the tests that open the dashboard; other keyless tests (redirect loop, env restart) still run.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughTwo keyless-related Playwright tests are modified across three integration test files to conditionally skip execution when the 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
Closing in favor of passing VERCEL_AUTOMATION_BYPASS_SECRET to the staging workflow (committed directly to main: 6540d1b). The bypass secret should allow keyless tests to access the staging dashboard without hitting Vercel SSO. |
Summary
E2E_STAGINGmodedashboard.clerkstage.dev) is behind Vercel SSO, so claim flow tests time out waiting for a Clerk sign-in page that never appearstest.skip()with reason, following existing patterns for framework/version skipsTests skipped in staging:
next-quickstart-keyless.test.ts— "Toggle collapse popover and claim", "Lands on claimed application..."react-router/keyless.test.ts— same two teststanstack-start/keyless.test.ts— same two testsTest plan
vercel.com/logininstead ofdashboard.clerkstage.dev/apps/claim/sign-inSummary by CodeRabbit