Skip to content

chore(repo): drop tailwind-merge from templates and playground#8536

Open
jacekradko wants to merge 2 commits into
mainfrom
jacek/drop-tailwind-merge
Open

chore(repo): drop tailwind-merge from templates and playground#8536
jacekradko wants to merge 2 commits into
mainfrom
jacek/drop-tailwind-merge

Conversation

@jacekradko
Copy link
Copy Markdown
Member

Nothing in packages/* uses tailwind-merge. The only consumers were two cn() helpers in the browser-extension playground and the custom-flows-react-vite integration template (and one stale dep declaration in the tanstack-react-start template). This drops the package and inlines cn() to clsx, and removes the trusted-publisher floor entries that pinned it.

Tradeoff worth noting: cn(defaults, className) in the affected shadcn-style components no longer resolves duplicate Tailwind utilities, so if a consumer passes a conflicting class, CSS source order wins instead of the call-site override. Acceptable for these template/demo surfaces.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

🦋 Changeset detected

Latest commit: a5c6979

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 13, 2026 1:38am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 80f5bbc6-2267-4a6a-b977-66c5ab06a392

📥 Commits

Reviewing files that changed from the base of the PR and between a233ddb and 7f02313.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • .changeset/drop-tailwind-merge.md
  • integration/constants.ts
  • integration/templates/custom-flows-react-vite/package.json
  • integration/templates/custom-flows-react-vite/src/lib/utils.ts
  • integration/templates/tanstack-react-start/package.json
  • package.json
  • playground/browser-extension/package.json
  • playground/browser-extension/src/utils/components.ts
💤 Files with no reviewable changes (4)
  • playground/browser-extension/package.json
  • package.json
  • integration/constants.ts
  • integration/templates/custom-flows-react-vite/package.json

📝 Walkthrough

Walkthrough

This PR removes the tailwind-merge dependency from the project's root configuration and two templates. The changeset documents the removal. Root package.json and integration/constants.ts no longer reference or override tailwind-merge. The custom-flows-react-vite and browser-extension templates remove the dependency and update their cn utilities to return clsx(inputs) without twMerge wrapping. The tanstack-react-start template removes the dependency from its manifest.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing tailwind-merge from templates and playground, which aligns with the changeset and PR objectives.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for removing tailwind-merge, its previous consumers, implementation changes, and a noted tradeoff.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 12, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8536

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8536

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8536

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8536

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8536

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8536

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8536

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8536

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8536

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8536

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8536

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8536

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8536

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8536

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8536

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8536

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8536

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8536

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8536

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8536

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8536

commit: a5c6979

…erge

# Conflicts:
#	playground/browser-extension/package.json
#	playground/browser-extension/src/utils/components.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant