Skip to content

Add commitlog knobs to server config#5074

Open
joshua-spacetime wants to merge 1 commit into
masterfrom
joshua/durability-knobs
Open

Add commitlog knobs to server config#5074
joshua-spacetime wants to merge 1 commit into
masterfrom
joshua/durability-knobs

Conversation

@joshua-spacetime
Copy link
Copy Markdown
Contributor

Description of Changes

Adds the commitlog knobs max_segment_size, write_buffer_size, and preallocate_segments to the server's config.toml. There are other seemingly more advanced knobs that I did not add at this time.

This patch also increases the DEFAULT_WRITE_BUFFER_SIZE from 8KiB to 128KiB to optimize high throughput workloads like the keynote-2 benchmark.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

Manual

@joshua-spacetime joshua-spacetime requested a review from kim May 19, 2026 20:33
Copy link
Copy Markdown
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine by me, but I'll note that commitlog config is exposed in the other edition, too, under a different key. It is probably not a good idea to let the config.toml diverge unless we have a good reason.

Also note that there is docs/docs/00300-resources/00200-reference/00100-cli-reference/00200-standalone-config.md, which I think should reflect these settings, even if they're deemed unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants