Conversation
bwesterb
reviewed
Feb 10, 2026
bwesterb
reviewed
Feb 10, 2026
Member
|
Why is it scary? |
Member
|
Still not safe. |
Member
|
We really shouldn't write this needless code. It's only more chances to get things wrong. |
Collaborator
Author
|
ok, fine. I've removed the check for all-0 keys. Now it's just a good'ol error handling bugfix. |
Collaborator
Author
|
BTW, why using |
Member
|
|
bwesterb
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's scary that the
MLKEM768_generate_keyis avoidfunction without ability to report an error. This adds a check that someseed/secretparseable public key has actually been written.