[Workers] Correct wildcard route pattern documentation and add zone context#31182
Draft
ask-bonk[bot] wants to merge 1 commit into
Draft
[Workers] Correct wildcard route pattern documentation and add zone context#31182ask-bonk[bot] wants to merge 1 commit into
ask-bonk[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
assigned
GregBrimble,
irvinebroque,
korinne,
MattieTK,
mikenomitch,
vy-ton and
WalshyDev
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://50d951e0.preview.developers.cloudflare.com Files with changes (up to 15) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects misleading examples in the Workers Routes documentation for hostnames beginning with
*.The previous documentation stated that
*example.com/*would not matchhttps://not-example.com/, which contradicts the definition that*matches zero or more of any character. This update fixes the example table and adds a note explaining that route patterns are evaluated within their associated zone, which means cross-domain hostnames likemyexample.comornot-example.comwould not reach theexample.comzone in practice.Additionally, this update adds subdomain wildcard examples (
*sub.example.com/*vs*.sub.example.com/*) to illustrate the more common and relevant scenario where unintended matches can occur within a zone.Fixes the feedback raised in the community regarding misleading/incorrect wildcard route pattern documentation.
Documentation checklist