Skip to content

[Sandbox] Add docs for Sandbox S3 credential proxy#31202

Open
scuffi wants to merge 3 commits into
productionfrom
scuffi/s3-credential-proxy
Open

[Sandbox] Add docs for Sandbox S3 credential proxy#31202
scuffi wants to merge 3 commits into
productionfrom
scuffi/s3-credential-proxy

Conversation

@scuffi
Copy link
Copy Markdown
Contributor

@scuffi scuffi commented Jun 3, 2026

Summary

This PR adds documentation for the S3 mount credential proxy implemented in cloudflare/sandbox-sdk#727

Documentation checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/sandbox/ @whoiskatrin, @ghostwriternr, @scuffi, @aron-cf, @thomasgauvin, @cloudflare/product-owners, @cloudflare/ai-agents

ask-bonk[bot]

This comment was marked as resolved.

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Jun 3, 2026

Clean documentation addition. One minor style guide fix suggested inline.

Summary: This PR adds documentation for the credentialProxy option in the Sandbox SDK, which routes S3 requests through a Durable Object proxy to keep real credentials out of the container. Changes span the Storage API reference (storage.mdx) and the Mount Buckets guide (mount-buckets.mdx).

Issue to address:

  • LOW src/content/docs/sandbox/api/storage.mdx:179 — Uses a semicolon. The style guide advises avoiding semicolons — break into shorter sentences instead. Inline suggestion posted.

Note: Consider updating the PR title to [Sandbox] Add docs for S3 credential proxy to match commit conventions.

@ask-bonk ask-bonk Bot added documentation Documentation edits content:new Request for new/missing content size/xs labels Jun 3, 2026
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Jun 3, 2026

Reviewed PR #31202. I posted an inline suggestion and added labels.

Findings:

  • LOW src/content/docs/sandbox/api/storage.mdx:179 — New text uses a semicolon, which the style guide advises avoiding. Posted an inline suggestion to split into two sentences.
  • Note — The PR title does not follow the commit convention format ([Product] description). Consider updating to [Sandbox] Add docs for S3 credential proxy.

Labels applied: documentation, content:new, size/xs

The PR is otherwise clean — accurate technical content, correct use of TypeScriptExample, proper heading structure, and valid frontmatter.

github run

@scuffi scuffi changed the title Add docs for Sandbox S3 credential proxy [Sandbox] Add docs for Sandbox S3 credential proxy Jun 3, 2026
@scuffi scuffi marked this pull request as ready for review June 3, 2026 11:25
@cloudflare-docs-bot
Copy link
Copy Markdown

cloudflare-docs-bot Bot commented Jun 3, 2026

Review

✅ No style-guide issues found in commit 9955af7.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:new Request for new/missing content documentation Documentation edits product:sandbox size/s size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants