Skip to content

[Logs] Update Logpush dataset field definitions (2026-06-03)#31217

Open
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-03
Open

[Logs] Update Logpush dataset field definitions (2026-06-03)#31217
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-03

Conversation

@soheiokamoto
Copy link
Copy Markdown
Contributor

Summary

Automated sync of Logpush dataset field definitions from data/entities.

Files changed

  • src/content/docs/logs/logpush/logpush-job/datasets/{account,zone}/ — dataset pages

Documentation checklist

  • Changelog entry — not applicable (no field additions or removals)
  • Content generated by code generator (DO NOT EDIT manually)

@soheiokamoto soheiokamoto requested review from a team and rianvdm as code owners June 3, 2026 17:10
@soheiokamoto
Copy link
Copy Markdown
Contributor Author

/bonk please review this automated sync of Logpush dataset field definitions.

Focus on the following:

  1. Changelog quality — is the entry clear, accurate, and useful to end users?

  2. Field description quality — are the descriptions accurate, clear, and complete?

  3. Manual edits at risk of being overwritten — are there any field descriptions that appear
    to have been manually edited directly in cloudflare-docs (e.g. contain context or guidance
    not present in the machine-generated description format)? If so, flag them so the author can
    preserve those edits in the internal source YAML.

@cloudflare-docs-bot
Copy link
Copy Markdown

cloudflare-docs-bot Bot commented Jun 3, 2026

Review

✅ No style-guide issues found in commit 2e0b797.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/logs/ @soheiokamoto, @angelampcosta, @rianvdm, @dcpena, @cloudflare/product-owners

@ask-bonk ask-bonk Bot added documentation Documentation edits content:edit Request for content edits labels Jun 3, 2026
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean automated sync with one style-guide fix. No manual edits at risk.

Issues

  • LOW — PR description references both {account,zone}/ datasets, but only zone/http_requests.md changed. Consider updating the description to match actual scope.
  • LOWaccount/mnm_flow_logs.md (also code-generated) still contains e.g. and etc. in field descriptions. Scrubbing the internal source YAML for these abbreviations will keep all generated pages consistent with the style guide.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Jun 3, 2026

I've completed the review of PR #31217.

What I checked:

  • Read the diff: a single-line change in zone/http_requests.md replacing e.g. with for example in the MatchedRules field description.
  • Verified against .agents/references/style-guide.md: it explicitly requires replacing e.g. with "for example", so this change improves compliance.
  • Scanned the file for manual-edit red flags (e.g. inconsistent formatting, editorial guidance not present elsewhere): none found.
  • Checked other generated dataset files for similar style debt: found account/mnm_flow_logs.md still contains e.g. and etc..

Actions taken:

  • Applied labels: product:logs, documentation, content:edit.
  • Posted a review comment on PR [Logs] Update Logpush dataset field definitions (2026-06-03) #31217 with two LOW severity items:
    1. The PR description mentions both {account,zone}/ datasets but only one zone file changed.
    2. account/mnm_flow_logs.md (also generated) still has e.g. / etc. — the internal source YAML should be scrubbed to prevent style debt.

Verdict: The diff itself is clean, accurate, and style-guide compliant. No manual edits appear to be at risk.

github run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:edit Request for content edits documentation Documentation edits product:logs Related to Logs size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants