Skip to content

[Smart Shield] Clarify Smart Shield Advanced availability for PayGo vs Enterprise#31218

Open
ngayerie wants to merge 2 commits into
productionfrom
ngayerie/DEE-3569
Open

[Smart Shield] Clarify Smart Shield Advanced availability for PayGo vs Enterprise#31218
ngayerie wants to merge 2 commits into
productionfrom
ngayerie/DEE-3569

Conversation

@ngayerie
Copy link
Copy Markdown
Collaborator

@ngayerie ngayerie commented Jun 3, 2026

Summary

Updates the Smart Shield get-started page and Regional Tiered Cache page to clarify that Smart Shield Advanced is currently only available to contracted (Enterprise) customers, not pay-as-you-go customers.

Changes:

  • get-started.mdx — Replaced the existing notes with a Tabs component separating "Contracted customers" and "Pay-as-you-go customers", making it clear that PayGo customers can only purchase Smart Shield and Smart Shield + Argo packages
  • regional-tiered-cache.mdx — Updated the availability note to state Smart Shield Advanced is Enterprise-only with a link to contact the Enterprise Sales team

Addresses DEE-3569.

Documentation checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/smart-shield/ @cloudflare/appsec-reviewers, @elithrar, @cloudflare/product-owners, @ncrouch-cflare

@ngayerie ngayerie force-pushed the ngayerie/DEE-3569 branch from eeaa4f3 to 502f4ac Compare June 3, 2026 17:24
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: Scope creep. This PR's single commit contains 218 changed files, but the title and description state intent to change only 2 Smart Shield files. Unrelated modifications are present across .agents/, src/components/, src/content/catalog-models/, .github/, and many other areas. These unintended changes must be removed before this PR can be merged.

Posted 3 inline suggestions for Tabs formatting in get-started.mdx.

Comment thread src/content/docs/smart-shield/get-started.mdx Outdated
Comment thread src/content/docs/smart-shield/get-started.mdx Outdated
Comment thread src/content/docs/smart-shield/get-started.mdx
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Jun 3, 2026

Review posted on PR #31218 with CHANGES_REQUESTED.

Summary of findings

CRITICAL (blocking): Scope creep. The PR description states intent to change only 2 Smart Shield files (get-started.mdx and regional-tiered-cache.mdx), but the single commit eeaa4f3 contains 218 changed files spanning many unrelated areas:

  • .agents/references/ and .agents/skills/
  • src/components/ (Astro components)
  • src/content/catalog-models/ (dozens of JSON files)
  • .github/, CONTRIBUTING.md, MIGRATION.md, etc.

This appears to be an accidental commit of all changes in the author's working tree. These unintended changes must be removed before merge.

LOW: Tabs formatting. In get-started.mdx, the <Tabs>, <TabItem>, and </TabItem> tags are placed on single lines (e.g., <Tabs> <TabItem label="Contracted customers">). The component reference shows these should be on separate lines. I posted 3 inline suggestions to fix this.

The actual Smart Shield content changes themselves appear technically sound: the import is correct, MDX syntax is valid, links use proper root-relative paths, and frontmatter is complete. Once the scope issue is resolved, the PR should be ready for re-review.

github run

@ngayerie ngayerie marked this pull request as ready for review June 3, 2026 21:06
@ngayerie ngayerie requested review from a team, elithrar and ncrouch-cflare as code owners June 3, 2026 21:06
@cloudflare-docs-bot
Copy link
Copy Markdown

cloudflare-docs-bot Bot commented Jun 3, 2026

Review

⚠️ 1 warning found in commit 3db6fd0.

Warnings (1)
File Issue
smart-shield/get-started.mdx line 77 Remove 'please' — Line adds 'please contact our' Fix: Remove 'please' and rephrase, e.g., 'contact our Enterprise Sales team'
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

@ngayerie ngayerie force-pushed the ngayerie/DEE-3569 branch from f3d7573 to 3db6fd0 Compare June 3, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.