feat(tunnel): add configuration hot reload support#1582
Open
lexfrei wants to merge 1 commit intocloudflare:masterfrom
Open
feat(tunnel): add configuration hot reload support#1582lexfrei wants to merge 1 commit intocloudflare:masterfrom
lexfrei wants to merge 1 commit intocloudflare:masterfrom
Conversation
f25e7e7 to
f8b2a3a
Compare
f8b2a3a to
2e8a997
Compare
Add hot reload capability for locally-managed tunnels. When a config file is specified (without --token), cloudflared now watches for changes and automatically reloads the configuration. Features: - File watching via fsnotify with 500ms debounce - Fallback polling every 30s for symlink rotation (Kubernetes ConfigMaps) - Manual reload via SIGHUP signal - Graceful handling of invalid configs (keeps current config) - Thread-safe with TryLock to skip concurrent reloads New files: - orchestration/local_config.go: Config file reading and validation - orchestration/local_watcher.go: File watcher with reload logic Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
9ff8814 to
7939127
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for hot reloading configuration without restarting cloudflared. This enables updating ingress rules, warp-routing settings, and origin request configuration on the fly.
Related issues: #240, #301, #512, #965
Changes
LocalConfigWatchercomponent that monitors config.yaml for changes via fsnotifyOrchestrator.UpdateConfig()mechanism (already used for remote-managed tunnels)Usage
What can be hot-reloaded
ingressruleswarp-routingoriginRequesttunnelUUIDcredentials-fileprotocolLimitations
Test plan
TestConvertLocalConfigToJSON*)TestValidateLocalConfig*)TestLocalConfigWatcher*)TestSignalShutdown)