Skip to content

fix: preserve tunnel flags during linux service install#1621

Open
d-padmanabhan wants to merge 1 commit intocloudflare:masterfrom
d-padmanabhan:fix/linux-service-install-flags
Open

fix: preserve tunnel flags during linux service install#1621
d-padmanabhan wants to merge 1 commit intocloudflare:masterfrom
d-padmanabhan:fix/linux-service-install-flags

Conversation

@d-padmanabhan
Copy link
Copy Markdown

Summary

  • Preserve supported explicit tunnel runtime flags during Linux service install
  • Reuse an allowlist-based serializer to prepend service-managed run args before tunnel run
  • Add regression tests covering string, int, duration, and bool flag pass-through

Test plan

  • gofmt -w cmd/cloudflared/common_service.go cmd/cloudflared/linux_service.go cmd/cloudflared/common_service_test.go
  • go test ./cmd/cloudflared/...
  • GOOS=linux GOARCH=amd64 go test -c -o /tmp/cloudflared_cmd_linux.test ./cmd/cloudflared

- Serialize supported tunnel runtime flags for service-managed runs
- Prepend explicit CLI flags before generated tunnel run arguments
- Add regression tests for string, int, duration, and bool flags
- Keep service-managed autoupdate flags out of pass-through args

Fixes the Linux service-install path where config-based installs dropped
generic tunnel flags like --edge-ip-version, causing generated systemd
units to ignore explicit runtime settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant