fix: use 'auto' as default protocol for quick tunnels#1627
Open
juliosuas wants to merge 1 commit intocloudflare:masterfrom
Open
fix: use 'auto' as default protocol for quick tunnels#1627juliosuas wants to merge 1 commit intocloudflare:masterfrom
juliosuas wants to merge 1 commit intocloudflare:masterfrom
Conversation
Quick tunnel was hardcoding 'quic' as the default protocol when no --protocol flag was specified, ignoring the documented default of 'auto'. The Cloudflare docs state that 'auto' is the default: https://developers.cloudflare.com/cloudflare-one/networks/connectors/cloudflare-tunnel/configure-tunnels/run-parameters/#protocol This caused quick tunnels to always use QUIC even in environments where HTTP/2 would be preferable or where QUIC is blocked. Fixes cloudflare#1609.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Quick tunnels (
cloudflared tunnel --url ...) hardcodequicas the default protocol when--protocolis not specified:The official docs state that
autois the default protocol, which lets cloudflared negotiate the best available protocol.This means users running quick tunnels in environments where QUIC is blocked (firewalls, some corporate networks) will get connection failures instead of a graceful HTTP/2 fallback.
Fix
One-line change:
"quic"→"auto"Fixes #1609.