Fix ICMPv6 proxy selecting ::1 instead of interface GUA on IPv6-only hosts#1628
Open
huhndev wants to merge 1 commit intocloudflare:masterfrom
Open
Fix ICMPv6 proxy selecting ::1 instead of interface GUA on IPv6-only hosts#1628huhndev wants to merge 1 commit intocloudflare:masterfrom
huhndev wants to merge 1 commit intocloudflare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1626
Summary
::1(loopback) as the IPv6 source address, making ICMPv6 proxying non-functionaldetermineICMPv6Srcmanually iterated network interfaces and picked the first IPv6 address found, which was::1onlo(enumerated first by the OS)findLocalAddr(UDP dial), matching the approach already used for IPv4 and letting the OS routing table select the correct source addressTest plan
::1 in zone loto the interface GUAmake testpasses (all tests, zero failures)make fmtandmake lintclean (at least no new warnings)