Fix race condition with sending a request while container is stopping#148
Draft
rushilmehra wants to merge 1 commit intomainfrom
Draft
Fix race condition with sending a request while container is stopping#148rushilmehra wants to merge 1 commit intomainfrom
rushilmehra wants to merge 1 commit intomainfrom
Conversation
commit: |
gabivlj
approved these changes
Feb 2, 2026
rushilmehra
force-pushed
the
rm/container-shutdown-race
branch
from
bde0a0a to
db3042c
Compare
rushilmehra
force-pushed
the
rm/container-shutdown-race
branch
2 times, most recently
from
f3ee562 to
abc450c
Compare
Due to some quirks in the runtime, it's possible for the DO to send a request to a container when it thinks the container is in a running state, but while the request is in flight, the container stops and the monitor promise resolves. This results in an error, and instead of retrying we throw a 500 error. Instead, recognize this case and restart the container. This is a bandage solution, but we will follow up with some improvements to the runtime that will clean up the state management required in this DO class.
rushilmehra
force-pushed
the
rm/container-shutdown-race
branch
from
abc450c to
5fd978a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to some quirks in the runtime, it's possible for the DO to send a request to a container when it thinks the container is in a running state, but while the request is in flight, the container stops and the monitor promise resolves. This results in an error, and instead of retrying we throw a 500 error. Instead, recognize this case and restart the container.
This is a bandage solution, but we will follow up with some improvements to the runtime that will clean up the state management required in this DO class.