Skip to content

Remove serde yaml, update some deps to the latest version.#181

Merged
TheJokr merged 8 commits intocloudflare:mainfrom
takashialpha:remove-serde-yaml
Mar 26, 2026
Merged

Remove serde yaml, update some deps to the latest version.#181
TheJokr merged 8 commits intocloudflare:mainfrom
takashialpha:remove-serde-yaml

Conversation

@takashialpha
Copy link
Copy Markdown
Contributor

serde_yaml was archived on March 25, 2024 and is no longer maintained,
generating CVE warnings for downstream consumers of this library. This is
a blocker for anyone depending on foundations who runs cargo audit or
similar auditing tools.

  • Replace serde_yaml with serde-saphyr, the actively maintained
    successor backed by the saphyr YAML parser
  • Drop yaml-merge-keys entirely — serde-saphyr handles YAML merge
    keys (<<:) natively and transparently during deserialization, making
    the explicit merge pass redundant
  • Simplify from_yaml_str from a three-step
    parse → Value → merge → deserialize pipeline down to a single
    serde_saphyr::from_str call
  • Bump several other workspace dependencies to their latest compatible
    versions (tokio, regex, thiserror, pin-project-lite, etc.)

No behaviour change. YAML merge key semantics are preserved — the
processing is now done inside serde-saphyr rather than as a manual
post-processing step.
Existing test suite passes unchanged. No new tests required as this is
a pure dependency substitution with equivalent semantics.

@TheJokr
Copy link
Copy Markdown
Collaborator

TheJokr commented Mar 25, 2026

Getting rid of serde-yaml would be nice. I added some commits to retain serde_path_to_error functionality, configure the serialization format, and fix tests (the serialization format changed in some ways that aren't configurable).

I also reverted the dependency bumps to keep the PR focused. There's no need to bump minor versions in a library.

@TheJokr TheJokr force-pushed the remove-serde-yaml branch 4 times, most recently from 266ad0e to b9da2c8 Compare March 25, 2026 18:17
@TheJokr TheJokr force-pushed the remove-serde-yaml branch from b9da2c8 to 74850a9 Compare March 25, 2026 18:20
@TheJokr TheJokr merged commit 576dddc into cloudflare:main Mar 26, 2026
18 checks passed
@TheJokr
Copy link
Copy Markdown
Collaborator

TheJokr commented Mar 26, 2026

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants