-
Notifications
You must be signed in to change notification settings - Fork 62
Adds vendored packages #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Then create a virtual environment and activate it from your shell: | ||
| ```console | ||
| python3.12 -m venv .venv | ||
| source .venv/bin/activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume these instructions are intended to be mac/linux specific? Maybe we can later add an OS picker that shows windows instructions... Though none of this is tested on windows at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should change these instructions to use uv? it makes installing a specific python version really easy (https://docs.astral.sh/uv/guides/install-python/#installing-a-specific-version) so should make it much easier for people to get this going.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection.
hoodmane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikenomitch. We should probably note somewhere that this is untested on windows to prevent possible frustration.
dom96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you.
Left one suggestion regarding uv, I don't think it's a blocker to merging this though.
Adds information about closed beta for python packages and an example we can point to in official docs