Add Support for addition Sentry Fields (Users, Request Data, Environment, Release)#40
Open
cycomachead wants to merge 19 commits intocloudflare:masterfrom
Open
Add Support for addition Sentry Fields (Users, Request Data, Environment, Release)#40cycomachead wants to merge 19 commits intocloudflare:masterfrom
cycomachead wants to merge 19 commits intocloudflare:masterfrom
Conversation
* `environment` in the initalizer or each event * `user` in the initalizer or each event * `request` in each event * `context` in each event
* fix a typo: context should be contexts
Snapcloud
Fix json object with invalid value and new features
|
It isn't that big of a merge... And it looks good to me. |
It was added upstream information which can be used when available.
Add more information into ngx raven sender.
Contributor
|
Why it wasn't merged, guys? :'( |
Contributor
|
@jdesgats consider merge of this, please |
Thanks to @nevmerzhitsky for the correction.
Sentry `release` should be `nil` when not set
|
Please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry this is one big PR. I've been meaning to try to upstream some changes for a while. If there's interest, consider this the start of a conversation — I can try to break this up as necessary.
Essentially, I've been using raven-lua pretty successfully in a Lapis (OpenResty) project. I've needed to extend this to support a few additional fields more common in traditional user-facing web apps.
environmentas a static property to the event payload, passed in during initializationserver_name. Can be passed in or defined withget_server_namerelease. Same deal as above. :)userandcontextstables to be passed tosend_reportget_request_datawhich was contributed to my fork by danifbento