Conversation
Contributor
|
UnknownError: "Overloaded" |
Contributor
|
@jasnell Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Collaborator
|
/bonk review this pr |
Contributor
|
UnknownError: Your AI Gateway has authentication active, but you didn't provide a valid apiKey |
Member
|
This is a way better design for a lexer. |
Member
|
I couldn't find any tests for ETag lexing though. Am I missing something? I think it would be easy to add a bunch of sample inputs to test. |
Collaborator
Author
|
@npaun ... There are a handful of tests in the internal repo |
npaun
approved these changes
Mar 31, 2026
Member
npaun
left a comment
npaun
left a comment
There was a problem hiding this comment.
Looks great. Still think it needs tests ;-)
Collaborator
Author
|
/bigbonk can haz review? |
Contributor
|
UnknownError: Your AI Gateway has authentication active, but you didn't provide a valid apiKey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the etag handling in R2 to avoid recursion and better handle edge cases. Handful of other drive by cleanups while I was there.