Skip to content

Check if file exists in object store before reusing #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IvanBorislavovDimitrov wants to merge 2 commits into
base: master
Choose a base branch
from
+442 −134

Fix comments

6084326
Select commit
Loading
Failed to load commit list.
Open

Check if file exists in object store before reusing #1801

Fix comments
6084326
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 26, 2026 in 1m 7s

Quality Gate failed

Failed conditions
78.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 266 in multiapps-controller-persistence/src/test/java/org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.cloudfoundry.multiapps.controller.persistence.services.FileStorageException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ0q3h2lX_pfP-bGEytO&open=AZ0q3h2lX_pfP-bGEytO&pullRequest=1801

Check warning on line 293 in multiapps-controller-persistence/src/test/java/org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.cloudfoundry.multiapps.controller.persistence.services.FileStorageException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ0q3h2lX_pfP-bGEytQ&open=AZ0q3h2lX_pfP-bGEytQ&pullRequest=1801

Check warning on line 282 in multiapps-controller-persistence/src/test/java/org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.cloudfoundry.multiapps.controller.persistence.services.FileStorageException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ0q3h2lX_pfP-bGEytP&open=AZ0q3h2lX_pfP-bGEytP&pullRequest=1801
View more details on SonarQubeCloud