docs(cluster): fix inaccurate docs and runbook SQL queries#829
Open
philippemnoel wants to merge 1 commit intocloudnative-pg:mainfrom
Open
docs(cluster): fix inaccurate docs and runbook SQL queries#829philippemnoel wants to merge 1 commit intocloudnative-pg:mainfrom
philippemnoel wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
dosubot
bot
added
size:L
Signed-off-by: Philippe Noël <philippemnoel@gmail.com>
philippemnoel
force-pushed
the
phil/docs-accuracy-fixes
branch
from
2546ab6 to
42db436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught these while working on the @paradedb fork. Figured these changes would benefit upstream and reduce our diff:
cluster.postgresql→cluster.postgresql.parameterswith correct nesting,cluster.initSQL→cluster.initdb.postInitSQLwith mention of the other init hooks, and a small grammar fixpg_subscriptioncatalog columns (subconninfo,subslotname,subsynccommit,subpublicationsinstead of the non-existentsrconninfo,srslotname, etc.), proper JOINs betweenpg_subscription,pg_stat_subscription, andpg_stat_subscription_stats, and COALESCE for nullable columnsnohupredirect order (> file 2>&1not2>&1 > file) and point the docs URL to the upstream repo instead of the paradedb forkEnjoy!