Skip to content

fix(java): set IsInterfaceMethod for interface methods#194

Merged
wzekin merged 1 commit into
cloudwego:mainfrom
wzekin:fix/java-is-interface-method
May 18, 2026
Merged

fix(java): set IsInterfaceMethod for interface methods#194
wzekin merged 1 commit into
cloudwego:mainfrom
wzekin:fix/java-is-interface-method

Conversation

@wzekin
Copy link
Copy Markdown
Collaborator

@wzekin wzekin commented May 18, 2026

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
In Java IPC mode cli.files is never populated, so the existing GetParent check in export.go could not detect interface parents and every interface method was emitted with IsInterfaceMethod=false.

Fall back to the receiver symbol's Kind (set to SKInterface by the IPC scanner via classKind(ci)) when the LSP-based check yields nil. Non-Java paths keep their original behaviour: when GetParent succeeds and reports an interface parent, the method is still skipped.

zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

In Java IPC mode `cli.files` is never populated, so the existing
`GetParent` check in export.go could not detect interface parents and
every interface method was emitted with `IsInterfaceMethod=false`.

Fall back to the receiver symbol's Kind (set to SKInterface by the
IPC scanner via `classKind(ci)`) when the LSP-based check yields nil.
Non-Java paths keep their original behaviour: when GetParent succeeds
and reports an interface parent, the method is still skipped.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@wzekin wzekin merged commit f7385d6 into cloudwego:main May 18, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants