Run tests on PHP 8.5 and update test environment #75
+121
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for testing on PHP 8.5 and updates the CI environment to use Windows 2025. It also updates reflection API usage to be compatible with PHP 8.1+ where setAccessible() is no longer required for accessing private/protected members.
Changes:
- Added PHP 8.5 to the CI test matrix
- Updated Windows runner from windows-2022 to windows-2025
- Wrapped all
setAccessible(true)calls with PHP version checks to avoid deprecation warnings on PHP 8.1+ - Updated dependency versions for react/child-process, react/event-loop, and react/promise
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | Added PHP 8.5 to test matrix and updated Windows runner to 2025 |
| composer.json | Updated dependency versions for react packages to support PHP 8.5 |
| tests/Io/ProcessIoDatabaseTest.php | Added PHP version checks around setAccessible() calls for PHP 8.1+ compatibility |
| tests/FunctionalFactoryTest.php | Added PHP version checks around setAccessible() calls for PHP 8.1+ compatibility |
| tests/FunctionalDatabaseTest.php | Added PHP version checks around setAccessible() calls for PHP 8.1+ compatibility |
| tests/FactoryTest.php | Added PHP version checks around setAccessible() calls for PHP 8.1+ compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #73, reactphp/child-process#119, reactphp/promise#264, reactphp/event-loop#282, and clue/framework-x#297