-
Notifications
You must be signed in to change notification settings - Fork 675
add k8gb governance review #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Josh Gavant <joshgavant@gmail.com>
8d414ca to
3a985ca
Compare
| ### Must-Fix Items | ||
|
|
||
| **The following issues have been identified that need to be resolved before | ||
| [project milestone or other requirement]:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the governance review team feel the project docs need to be updated before incubation vote?
| **Governance has continuously been iterated upon by the project as a result of | ||
| their experience applying it, with the governance history demonstrating | ||
| evolution of maturity alongside the project's maturity evolution.** | ||
| **Incubating:** Suggested | **Graduated:** Suggested | ||
|
|
||
| There has been little change to | ||
| [GOVERNANCE](https://github.com/k8gb-io/k8gb/blob/master/GOVERNANCE.md) since it | ||
| was written several years ago. [CODEOWNERS | ||
| history](https://github.com/k8gb-io/k8gb/commits/master/CODEOWNERS) shows | ||
| onboarding and offboarding of maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the governance file specified an election to be held, and the code owners file change PRs don't indicate a corresponding election, I would say they are not adhering to their governance as written.
| The project plans to move to a vendor-neutral API group in the future instead of | ||
| `k8gb.absa.oss`, see <https://github.com/k8gb-io/k8gb/issues/2180>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is considered blocking.
| - The process for choosing the project lead should be described. | ||
| - Who the project lead is should be indicated somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have since been resolved
| **Incubating:** Suggested | **Graduated:** Required | ||
|
|
||
| Maintainers are added to CODEOWNERS following a period of contributions to the | ||
| project. They are removed voluntarily or per a supermajority vote of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| project. They are removed voluntarily or per a supermajority vote of | |
| project via an election process. They are removed voluntarily or per a supermajority vote of |
Closes #1963
cc @kashifest @TheFoxAtWork @rochaporto