fix : use default service account for cockroachdb-client-secure#970
Open
bhismnarayan wants to merge 2 commits intocockroachdb:masterfrom
Open
fix : use default service account for cockroachdb-client-secure#970bhismnarayan wants to merge 2 commits intocockroachdb:masterfrom
bhismnarayan wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Member
|
|
bhismnarayan
changed the title
Contributor
Author
|
@cockroach-teamcity @dt @prafull01 can you please review |
prafull01
reviewed
Apr 7, 2025
bhismnarayan
force-pushed
the
update_service_account
branch
from
9cdb2b7 to
bef74a2
Compare
prafull01
reviewed
Apr 15, 2025
Contributor
prafull01
left a comment
prafull01
left a comment
There was a problem hiding this comment.
Please update the PR's heading which reflects its changes.
bhismnarayan
changed the title
Contributor
Author
|
@prafull01 can you please review? |
prafull01
approved these changes
Apr 24, 2025
Contributor
|
@bhismnarayan Can you please rebase your branch. |
bhismnarayan
force-pushed
the
update_service_account
branch
from
bef74a2 to
87f0b5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client-secure-operator.yaml has reference to a service account
cockroachdb-sawhich not being created but was referred.Checklist
*In order to fix it I added code block to create
cockroachdb-saservice account