drpcyamux: add yamux multiplexing support for concurrent RPCs#18
Open
shubhamdhama wants to merge 1 commit intocockroachdb:mainfrom
Open
drpcyamux: add yamux multiplexing support for concurrent RPCs#18shubhamdhama wants to merge 1 commit intocockroachdb:mainfrom
shubhamdhama wants to merge 1 commit intocockroachdb:mainfrom
Conversation
shubhamdhama
commented
Oct 31, 2025
| module storj.io/drpc | ||
|
|
||
| go 1.19 | ||
| go 1.23.0 |
Author
There was a problem hiding this comment.
I'll update this once and for all in a separate PR.
This package enables multiple concurrent RPCs over a single connection using HashiCorp's yamux multiplexer. It's based on https://gitea.elara.ws/Elara6331/drpc but almost rewritten to fix critical concurrency issues and resource leaks. Key improvements over the original: - Fixed race conditions on connection state using sync.Once and channels - Eliminated goroutine leaks in stream cleanup and server shutdown paths - Proper graceful shutdown with WaitGroups throughout the server stack - Thread-safe idempotent Close() on both client and server - Simplified error handling in session Accept loop - Context-aware shutdown that properly unblocks blocking operations The package provides two main components: - Conn: Client-side drpc.Conn implementation with yamux multiplexing - Server: Server that accepts yamux sessions and handles streams concurrently
9fc94c4 to
4118e5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package enables multiple concurrent RPCs over a single connection using HashiCorp's yamux multiplexer. It's based on https://gitea.elara.ws/Elara6331/drpc but some parts are rewritten to fix critical concurrency issues and resource leaks.
Key improvements over the original:
The package provides two main components: