Skip to content

ENV - added / at the end of the url#2293

Merged
Didayolo merged 1 commit intodevelopfrom
env_sample_update
Mar 27, 2026
Merged

ENV - added / at the end of the url#2293
Didayolo merged 1 commit intodevelopfrom
env_sample_update

Conversation

@ihsaan-ullah
Copy link
Copy Markdown
Collaborator

@ihsaan-ullah ihsaan-ullah commented Mar 26, 2026

Description

Added / to the end of the url in env sample. Without this change the url is incorrect when used in the compute worker

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Copy Markdown
Member

Is this related to the bug I reported in #2285? Or a bug you have locally?

I never had problem with this.

@Didayolo Didayolo self-assigned this Mar 27, 2026
@Didayolo Didayolo self-requested a review March 27, 2026 09:27
@Didayolo Didayolo merged commit 837042f into develop Mar 27, 2026
1 check passed
@Didayolo Didayolo deleted the env_sample_update branch March 27, 2026 09:39
@ihsaan-ullah
Copy link
Copy Markdown
Collaborator Author

Is this related to the bug I reported in #2285? Or a bug you have locally?

I never had problem with this.

This is not a reported bug. I think you added a slash / in your version of .env. I added it in this PR so that users know that a slash at the end is required in order to have a working url e.g. http://minio:9000/private is valid but http://minio:9000private is not valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants