Skip to content

Compute Worker- reorganzing and cleaning of compute worker#2294

Open
ihsaan-ullah wants to merge 2 commits intodevelopfrom
compute_worker_cleaning
Open

Compute Worker- reorganzing and cleaning of compute worker#2294
ihsaan-ullah wants to merge 2 commits intodevelopfrom
compute_worker_cleaning

Conversation

@ihsaan-ullah
Copy link
Copy Markdown
Collaborator

@ihsaan-ullah ihsaan-ullah commented Mar 26, 2026

Description

This PR cleans the compute worker code and uses settings and other new classes for better readability and debugging

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah
Copy link
Copy Markdown
Collaborator Author

Some points for discussion:

  • At 2 places in the compute worker code logger.debug(...) is used withtout checking if LOG_LEVEL is set to debug. Should this be fixed?
  • Do you think the following 3 constants are ok to be placed in the new Settings class or should they be placed somewhere else?
 # Constants
  DOCKER = "docker"
  PODMAN = "podman"
  LOG_LEVEL_DEBUG = "debug"

@Didayolo Didayolo mentioned this pull request Mar 27, 2026
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant