-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(plugin-axe): omit URL from issues when analyzing single URL #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit e425a68
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
86037b4 to
e425a68
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 5f60b3d with previous commit f51d768. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 3 audits improved, 👎 3 audits regressed, 16 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
657 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 5f60b3d with previous commit f51d768. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 67 | 🟡 68 | |
| Code coverage | 🟢 93 | 🟢 93 |
4 other categories are unchanged.
👍 2 groups improved, 👍 3 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 67 | 🟡 68 | |
| Code coverage | Code coverage metrics | 🟢 93 | 🟢 93 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Functions coverage | 🟥 24 undocumented functions | 🟥 24 undocumented functions | |
| Code coverage | Line coverage | 🟨 69.5 % | 🟨 69.7 % | |
| Code coverage | Branch coverage | 🟨 86.2 % | 🟨 86.3 % |
440 other audits are unchanged.
💼 Project plugin-lighthouse
😟 Code PushUp report has regressed.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 99 | 🟢 99 |
5 other categories are unchanged.
👎 1 group regressed, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 96.2 % | 🟩 96.2 % |
443 other audits are unchanged.
12 other projects are unchanged.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Omit URL from issue messages when analyzing a single URL.
Previously, every issue included the analyzed URL in parentheses, e.g.:
This is useful for multi-URL setups to identify which page an issue came from, but adds noise when there's only one URL.