Skip to content

docs: update Z.ai Coding Plan model from GLM-4.7 to GLM-5#2129

Open
imwxc wants to merge 3 commits intocode-yeongyu:devfrom
imwxc:docs/update-zhipuai-glm5
Open

docs: update Z.ai Coding Plan model from GLM-4.7 to GLM-5#2129
imwxc wants to merge 3 commits intocode-yeongyu:devfrom
imwxc:docs/update-zhipuai-glm5

Conversation

@imwxc
Copy link

@imwxc imwxc commented Feb 26, 2026

Summary

  • Update Z.ai Coding Plan documentation to reflect the latest GLM-5 model
  • Update Librarian, Sisyphus, and Oracle agent model references from glm-4.7 to glm-5
  • Keep glm-4.7-flash for Explore agent (GLM-5 flash variant not yet available)

Changes

File Change
docs/guide/installation.md Updated Z.ai Coding Plan section with GLM-5 models
docs/configurations.md Updated librarian example config
docs/guide/overview.md Updated example config with glm-5 references

Test Plan

  • Verified all documentation files are consistent
  • Preserved glm-4.7-flash for Explore agent (no glm-5-flash available yet)

Summary by cubic

Switch Z.ai Coding Plan from GLM-4.7 to GLM-5 across docs and defaults. Librarian, Sisyphus, and Oracle now use GLM-5; Explore stays on glm-4.7-flash until a GLM-5 flash variant exists.

  • Bug Fixes
    • Updated ZAI_MODEL constant and fallback chains (Sisyphus, Librarian, relevant category models) to glm-5.
    • Synced tests and snapshots with the new defaults.
    • Refreshed docs (installation, overview, configurations) to reference glm-5.

Written for commit b5c0058. Summary will update on new commits.

- Update Librarian agent model to glm-5
- Update Sisyphus and Oracle models in Z.ai-only scenario
- Update configuration examples in overview.md and configurations.md
- Keep glm-4.7-flash for Explore agent (no glm-5-flash available)
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Confidence score: 3/5

  • The change introduces a concrete user-facing mismatch: docs/guide/installation.md documents GLM-5 integration while the actual OpenCode behavior remains GLM-4.7, which can mislead users.
  • Severity is high (8/10) with high confidence, so there’s some risk of confusion or misconfiguration despite being a documentation-only change.
  • Pay close attention to docs/guide/installation.md - ensure the GLM-5 guidance matches real OpenCode integration behavior.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/guide/installation.md">

<violation number="1" location="docs/guide/installation.md:203">
P1: Custom agent: **Opencode Compatibility**

Opencode Compatibility rule violation: the new GLM-5 documentation does not match the actual OpenCode integration behavior (still GLM-4.7), so the changed guidance is incompatible with current implementation.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@imwxc
Copy link
Author

imwxc commented Feb 26, 2026

I have read the CLA Document and I hereby sign the CLA

@imwxc
Copy link
Author

imwxc commented Feb 26, 2026

recheck

github-actions bot added a commit that referenced this pull request Feb 26, 2026
@imwxc imwxc changed the base branch from master to dev February 27, 2026 11:47
@imwxc
Copy link
Author

imwxc commented Feb 27, 2026

⚠️ Documentation-Code Mismatch

This PR updates the documentation to reference glm-5, but the actual code implementation still uses glm-4.7:

Code Implementation (Current)

// src/cli/model-fallback.ts
const ZAI_MODEL = "zai-coding-plan/glm-4.7"

// src/shared/model-requirements.ts
librarian: {
  fallbackChain: [
    { providers: ["zai-coding-plan"], model: "glm-4.7" },
    ...
  ],
}

Options

  1. Update code first: If Z.ai Coding Plan now supports GLM-5, update the code implementation to use glm-5, then the documentation will be accurate.

  2. Revert documentation changes: If Z.ai does not yet support GLM-5 in the zai-coding-plan provider, the documentation should not be updated.


This PR should either include corresponding code changes or be modified to match the current implementation.

@imwxc
Copy link
Author

imwxc commented Feb 27, 2026

🔧 Required Code Changes

To sync the implementation with this documentation update, the following code changes are needed:

1. src/cli/model-fallback.ts

-const ZAI_MODEL = "zai-coding-plan/glm-4.7"
+const ZAI_MODEL = "zai-coding-plan/glm-5"

2. src/cli/model-fallback-requirements.ts

 sisyphus: {
   fallbackChain: [
     ...
-    { providers: ["zai-coding-plan"], model: "glm-4.7" },
+    { providers: ["zai-coding-plan"], model: "glm-5" },
   ],
 },

 librarian: {
   fallbackChain: [
-    { providers: ["zai-coding-plan"], model: "glm-4.7" },
+    { providers: ["zai-coding-plan"], model: "glm-5" },
     ...
   ],
 },

3. Test Updates Required

  • src/cli/model-fallback.test.ts - update expectations
  • src/cli/config-manager.test.ts - update expectations
  • Update snapshots with bun test --update-snapshots

Note: The glm-4.7-free model (OpenCode Zen) should NOT be changed as it's a different provider/model.

Would you like me to help add these code changes to this PR?

- Update model-fallback.ts: ZAI_MODEL constant
- Update model-requirements.ts: sisyphus, librarian, writing fallback chains
- Update test expectations and snapshots
@imwxc
Copy link
Author

imwxc commented Feb 27, 2026

🔧 Code Sync Complete

Based on the review feedback, I've updated the code implementation to match the documentation:

Code Changes

  • src/cli/model-fallback.ts: ZAI_MODEL = glm-5
  • src/shared/model-requirements.ts: sisyphus, librarian, writing fallback chains

Test Updates

  • Updated test expectations in model-fallback.test.ts and model-requirements.test.ts
  • All 55 tests pass ✅

The documentation and code are now synchronized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant