fix(comment-checker): bump dependency to ^0.7.0 for --prompt support#2131
Open
maou-shonen wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(comment-checker): bump dependency to ^0.7.0 for --prompt support#2131maou-shonen wants to merge 1 commit intocode-yeongyu:devfrom
maou-shonen wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Corrects a version mismatch in package.json where a 0.x dependency was pinned too low to support a flag already being used. Fixes a silent failure with minimal risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I always felt like comment-checker wasn't doing anything when I had
custom_promptconfigured. After digging into it, turns out it's been silently failing every time.465c9e51added--promptflag support, butpackage.jsonstill has^0.6.1. Since this is a 0.x package, caret semantics mean>=0.6.1 <0.7.0— so v0.7.0 (which actually has the--promptflag) never gets installed.When v0.6.x receives an unknown flag, cobra exits with code 0. The hook treats exit 0 as "no comments detected", so the entire check is silently skipped with no error or warning.
Fix
Bump
@code-yeongyu/comment-checkerfrom^0.6.1to^0.7.0.Summary by cubic
Bumped @code-yeongyu/comment-checker to ^0.7.0 to add --prompt support. This fixes silent skips where v0.6.x treated the unknown flag as “no comments” when custom_prompt is set.
Written for commit acb51d1. Summary will update on new commits.