fix: remove config-context console.warn that leaks into TUI textbox#2184
Open
mertyldrm wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix: remove config-context console.warn that leaks into TUI textbox#2184mertyldrm wants to merge 1 commit intocode-yeongyu:devfrom
mertyldrm wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Removing a console.warn inside a non-production check is safe and fixes a TUI rendering glitch without changing core logic.
getConfigContext() emitted a console.warn when called before initConfigContext() completed. Since initConfigContext runs async (spawns opencode --version subprocess), other modules calling getConfigDir/getConfigJson could trigger this warning during startup. The fallback behavior is intentional and safe (defaults to standard CLI paths), but console.warn writes to stderr which the TUI captures, causing the warning to render inside the user's textbox. Fixes code-yeongyu#2183
mertyldrm
force-pushed
the
fix/config-context-warning-leak
branch
from
1fccf80 to
83c024d
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.warningetConfigContext()that renders inside the TUI textbox during startupProblem
initConfigContext()runs async (spawnsopencode --versionsubprocess), but modules callinggetConfigDir()/getConfigJson()can resolve synchronously before it completes. Theconsole.warnwrites to stderr, which the TUI captures, causing the warning to appear in the user's input textbox.Fixes #2183
Summary by cubic
Removed console.warn in getConfigContext() that wrote to stderr and leaked into the TUI input box during startup. Behavior unchanged: if initConfigContext() hasn’t completed, we default to standard CLI paths.
Written for commit 83c024d. Summary will update on new commits.