feat(start-work): add auto_commit config option#2198
Open
acamq wants to merge 2 commits intocode-yeongyu:devfrom
Open
feat(start-work): add auto_commit config option#2198acamq wants to merge 2 commits intocode-yeongyu:devfrom
acamq wants to merge 2 commits intocode-yeongyu:devfrom
Conversation
Add start_work.auto_commit configuration option to allow users to disable the automatic commit step in the /start-work workflow. When auto_commit is false: - STEP 8: COMMIT ATOMIC UNIT is removed from orchestrator reminder - STEP 9: PROCEED TO NEXT TASK becomes STEP 8 Resolves code-yeongyu#2197
There was a problem hiding this comment.
2 issues found across 9 files
Confidence score: 5/5
- This PR looks safe to merge since the issues are documentation-only with low severity and no runtime impact
- The most notable issue is duplicated schema tree lines in
src/config/AGENTS.md, which could confuse readers but won’t affect behavior - Pay close attention to
src/config/AGENTS.md- duplicated entries and a stray '7ZB|' keystroke in the docs
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/config/AGENTS.md">
<violation number="1" location="src/config/AGENTS.md:7">
P2: Accidental keystroke insertion '7ZB|' corrupts documentation text</violation>
<violation number="2" location="src/config/AGENTS.md:36">
P2: Duplicated entries in schema tree - lines 36-37 duplicate lines 34-35</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Remove accidental '7ZB|' keystroke insertion on line 7 - Remove duplicate schema tree entries (start-work.ts and internal/permission.ts)
Contributor
Author
|
@cubic-dev-ai recheck please |
@acamq I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 9 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds a configuration option to toggle auto-commit; standard plumbing through config schemas, hooks, and UI logic with no breaking changes or regressions identified.
But I wonder if your implementation is useful for saving tokens and processes. It should eliminate unnecessary steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_work.auto_commitconfiguration option to allow users to disable the automatic commit step in the/start-workworkflowauto_commitisfalse, "STEP 8: COMMIT ATOMIC UNIT" is removed from the orchestrator reminder and step numbering is adjusted accordinglyUsage
Users can now disable auto-commit in their configuration file:
{ "start_work": { "auto_commit": false } }Changes
src/config/schema/start-work.tsstart_workconfig withauto_commit: boolean(default:true)src/config/schema/oh-my-opencode-config.tsstart_workto root schemasrc/hooks/atlas/types.tsautoCommittoAtlasHookOptionssrc/hooks/atlas/atlas-hook.tsautoCommitoption to tool handlerssrc/hooks/atlas/tool-execute-after.tsautoCommittobuildOrchestratorRemindersrc/hooks/atlas/verification-reminders.tssrc/plugin/hooks/create-continuation-hooks.tscreateAtlasHookVerification
start_workoptionResolves #2197
Summary by cubic
Adds a start_work.auto_commit config to let users turn off automatic commits in the /start-work workflow. When disabled, the orchestrator reminder hides the commit step and renumbers the next step.
New Features
Bug Fixes
Written for commit 5e726a2. Summary will update on new commits.