Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,15 @@ jobs:
restore-keys: |
${{ runner.os }}-yarn-

- name: 🪟 Pin hermes-compiler for Windows
# hermes-compiler v1+ doesn't ship Windows binaries, pin to 0.14.1 which does
shell: bash
run: node -e "const p=require('./package.json'); p.resolutions['hermes-compiler']='0.14.1'; require('fs').writeFileSync('package.json', JSON.stringify(p, null, 2) + '\n')"

- name: 🧶 Install node modules in root dir
# NOTE(cedric): yarn v1 on Windows has networking issues, we need to set `--network-timeout` to a higher value
# NOTE(@kitten): --ignore-engines is needed due to Node 18 being required (see above)
run: yarn install --prefer-offline --frozen-lockfile --network-timeout 1000000 --ignore-engines
run: yarn install --prefer-offline --network-timeout 1000000 --ignore-engines
env:
YARN_IGNORE_SCRIPTS: 'true'

Expand Down
20 changes: 16 additions & 4 deletions apps/bare-expo/ios/BareExpo.xcodeproj/project.pbxproj

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions apps/bare-expo/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ require 'json'
podfile_properties = JSON.parse(File.read(File.join(__dir__, 'Podfile.properties.json'))) rescue {}

ENV['EX_DEV_CLIENT_NETWORK_INSPECTOR'] ||= podfile_properties['EX_DEV_CLIENT_NETWORK_INSPECTOR']
ENV['RCT_USE_RN_DEP'] ||= '1' if podfile_properties['ios.buildReactNativeFromSource'] != 'true'
ENV['RCT_USE_PREBUILT_RNCORE'] ||= '1' if podfile_properties['ios.buildReactNativeFromSource'] != 'true'
ENV['RCT_USE_RN_DEP'] ||= '0' if podfile_properties['ios.buildReactNativeFromSource'] == 'true'
ENV['RCT_HERMES_V1_ENABLED'] ||= '1' if podfile_properties['expo.useHermesV1'] == 'true'
ENV['RCT_USE_PREBUILT_RNCORE'] ||= '0' if podfile_properties['ios.buildReactNativeFromSource'] == 'true'

platform :ios, podfile_properties['ios.deploymentTarget'] || '15.1'

Expand Down
Loading
Loading