Conversation
# Why When a page has multiple `<Prerequisites>` components (e.g., https://docs.expo.dev/submit/ios/ or https://docs.expo.dev/deploy/submit-to-app-stores), navigating to the anchor link of any instance other than the first does not scroll to the correct position. The anchor link URL itself was correct (e.g., #prerequisites-1), but the `<details>` element's id was hardcoded to "prerequisites" for every instance. Since no DOM element had the matching id, the browser couldn't scroll to it and the hash-based auto-expansion didn't trigger. # How Changed the id attribute on the `<details>` element in `ui/components/Prerequisites/index.tsx` from the hardcoded `anchorId` ("prerequisites") to heading.current.slug, which is the unique slug already used by the anchor link href. # Test Plan Tested on a few pages locally to see that it works as intended. # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…dge cases (#43610) # Why Adding tests demonstrating that `path` and `version` are stable across dependency orderings when multiple parents share a pnpm-isolated dependency. The `_visitedPackagePaths` race in `scanDependenciesRecursively` determines which parent sets the version, but `mergeWithDuplicate` correctly transfers it in all cases. The sole non-deterministic field is `originPath`, which is internal and unused outside diagnostics. This is based on tests in an issue to validate that the output is deterministic for (non-corrupted) isolated dependency installations Related #43517 # How - Add a few more tests from issue analysis # Test Plan # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why There is currently no easy way to show/hide jetpack components in an easy way. # How Add `AnimatedVisibility` component. In the follow-up PR I would like to add an API similar to `modifiers` for configuring the entry/exit animation # Test Plan https://github.com/user-attachments/assets/0ae69a0e-58ef-433f-be4a-b63a64408685 # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…art` (#43619) # Why This is only a slight annoyance, but there's no point for us to fail `expo start` when dependency validation fails. There isn't even any real point to show the error, since it's a non-essential task. I saw this failing for someone on Discord and it's really confusing to see # How - Add empty try-catch to dependency validation in `expo start` # Test Plan - n/a # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )