Conversation
Co-authored-by: Aman Mittal <10234615+amandeepmittal@users.noreply.github.com>
# Fix Android Switch ripple effect clipped on sides ## Summary Fixes #43554 The Switch ripple effect on Android was clipped to a rectangle instead of rendering as a circle extending beyond the component bounds. ## Root cause `ExpoComposeView` extends `ExpoView` which extends `LinearLayout`. By default, `LinearLayout` has clips the children. Also, `ExpoView.dispatchDraw()` calls `clipToPaddingBox(canvas)` which clips the drawing canvas to the view's bounds before dispatching to children. When `Host` uses `matchContents`, the view is sized to exactly fit the Switch content. The ripple effect on the Switch thumb gets cut off at the view boundary. ## Fix Disable `clipChildren` and `clipToPadding` on `ExpoComposeView` when `withHostingView = true` - `clipToPadding = false` — skips the `clipToPaddingBox` canvas clipping in `dispatchDraw`, allowing content (ripples, shadows) to render outside view bounds - `clipChildren = false` — allows child views to draw outside their own bounds within the parent ## Test plan - Open NCL → Expo UI → Switch on Android - The ripple should render as a circle, not clipped on the sides # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…e 0.83 (#43682) # Why Closes #43645 # How Add version mapping for SDK 55 and react native 0.83 to install-expo-modules # Test Plan Tested locally # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…43606) # Why While it's assumed that we'd always have a routes manifest, this isn't always the case. `getRoutesCore` itself self-documents that a tutorial is displayed when no routes are present, and it returns `null` for the directory structure. This `null` value is carried through to where the routes output is used, until the manifests are created. There, we instead unfortunately throw an error. This is a pre-condition that's instead asserted as an error, which is unexpected, and leads to unintended cases where the build cryptically fails. We should aim not to fail the build even when the app is in an "intermediary" state. See: #43602 Specifically, I believe we should gracefully continue building the app as often as possible, even if prerequisites aren't fulfilled. In this case, when no routes are present, we should continue building. If we want to enforce the "no routes" case, we should add a clear error in a place where we handle build exceptions instead. # How - Prevent `null` route tree from throwing when manifests are generated - Prevent `null` route tree from throwing when static react-navigation configs are generated # Test Plan - Build without an `app` folder and observe that the build shouldn't fail - Example: `E2E_ROUTER_SRC=noop expo export -p web` in `router-e2e` # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Reverts: - 2619169 - 5b34e1d # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan 1. Clean repo `git clean -fdx` 2. Build expo-go & test it with latest SDK-55 example (with screens bumped to 4.24.0) 4. Build and test bare-expo 5. Build router-e2e and test # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Co-authored-by: Aman Mittal <10234615+amandeepmittal@users.noreply.github.com>
Co-authored-by: Aman Mittal <10234615+amandeepmittal@users.noreply.github.com>
…3696) Co-authored-by: Aman Mittal <10234615+amandeepmittal@users.noreply.github.com>
# Why - We should test that dev menu displays correctly in brownfield (as it requires some modifications in brownfield in order to work) and we can do it using Maestro - Tests and workflows for brownfield are a bit duplicated and have leftover filters, etc. - we can refine that # How `test-suite-brownfield-isolated.yml` To avoid using matrices and using additional 2 runners: - Extended existing build jobs with building & uploading of debug apps - Extended existing test jobs with additional execution of Maestro tests against the debug apps `brownfield.yml` - Removed unused cli and plugin path filters - Removed `packages/expo-brownfield/**` filter for compilation tests - this is now covered by Maestro E2Es workflow - Extended filters for iOS compilation test with `'packages/expo-modules-core/ios/**'` - commits there aren't very frequent, but it affects `expo-brownfield` and now with ccache and prebuilts we should be able to run it more often **E2Es** - Unified common test flows (e.g. for launching the app or skipping initial dev menu) - Added `dev-menu.yml` workflow - Removed `android/basic.yml` and `ios/basic.yml` as all they do is anyway covered by other test suites - Unified workflows `navigation.yml` and `communication.yml` - Updated test apps # Test Plan Ensured that tests pass locally and on CI # Checklist - [X] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Gabriel Donadel <donadeldev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )